Remove sources from schema and consolidate its URL field into caseReference
#372
Conversation
|
|
||
| Returns: | ||
| None: When the input is empty. | ||
| Dict[str, str]: When the input is nonempty. The dictionary is in the | ||
| format: | ||
| { | ||
| 'url': str, | ||
| 'other': str | ||
| 'sourceUrl': str, |
There was a problem hiding this comment.
Granted there's no real sourceId for this data, but it's a little odd that we're inserting data that disagrees with our Mongoose validation rules. Is it worth filling the ID with a hash of the URL (or perhaps some portion of it)?
Mostly related: should we add a required stanza(s) in our json schema?
There was a problem hiding this comment.
Granted there's no real
sourceIdfor this data, but it's a little odd that we're inserting data that disagrees with our Mongoose validation rules. Is it worth filling the ID with a hash of the URL (or perhaps some portion of it)?
I guess I was hoping we'd be able to backfill some of these ids, after we've added some data to the sources collection -- does that sound reasonable, and if reasonable, worth it?
Mostly related: should we add a
requiredstanza(s) in our json schema?
unfortunately, there are a few existing cases that do not have a source URL, so they would fail to validate & insert into the db :( I can look into getting those fixed upstream though and then we can make it required
Sorry it's so huge :\ I tried to break commits up somewhat logically
Note: I made
caseReferencerequired, as well ascaseReference.sourceUrl